Skip to content

Conversation

@Hristo313
Copy link
Contributor

@Hristo313 Hristo313 commented Feb 24, 2025

Fix errors when running ng/npm run test command for angular, react and wc

@coveralls
Copy link

coveralls commented Feb 24, 2025

Coverage Status

coverage: 70.044%. remained the same
when pulling fcbf24e on hhristov/fix-automation-errors
into 9168447 on master.

- run: npm run lint
- run: npm run build
- run: npm run test -- --watch=false --browsers ChromeHeadless
- run: NODE_OPTIONS="--max-old-space-size=6000" npm run test -- --watch=false --browsers ChromeHeadless
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly sure if we should add the flag here as this will also add it for all generated project. This may not be ideal if its sole purpose is to allow the automation on generated apps to run properly. It does not seem to be needed when publishing to GitHub and running the CI - link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it form the yml files and added it to the package.json files

@Hristo313 Hristo313 changed the title fix: handle automation errors fix test errors Feb 25, 2025
@Lipata Lipata merged commit d52c0f9 into master Feb 28, 2025
3 checks passed
@Lipata Lipata deleted the hhristov/fix-automation-errors branch February 28, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants